| | <<<Back 1 day (to 2015/12/14) | 20151215 |
| tor8 | Robin_Watts: I'm rewriting stuff to consistently use fz_output for writing data, and now I've run into the stuff that write directly to fz_buffer (fz_buffer_printf, fz_buffer_write_byte, etc) | 11:15.44 |
| | I mean fz_write_buffer_x | 11:16.46 |
| Robin_Watts | ok... | 11:56.27 |
| tor8 | Robin_Watts: ... but I think I'll leave that for later | 12:23.11 |
| | I've done a bit of renaming of functions, the proliferation of different names was getting a bit confusing | 12:23.26 |
| | and inconsistent use of the same word | 12:23.45 |
| | only one or two should affect our "public" interfaces | 12:24.09 |
| Robin_Watts | ok. | 12:36.54 |
| Robin_Watts | invents tor13. It's like rot13, but backwards. | 12:37.50 |
| | tor8: Will we ever want to be able to fz_save_document to an fz_output? | 12:42.20 |
| | If so, then keeping the options called fz_write_options would be correct. | 12:42.37 |
| | but, lgtm. | 12:45.51 |
| tor8 | Robin_Watts: good point | 12:46.40 |
| | will rename the options struct back to fz_write_options | 12:46.54 |
| Robin_Watts | There is a note in there that fz_write_options should be moved out of the fz side and into the pdf side. | 12:47.19 |
| | My intent when I created the fz_write stuff was that it was generic. | 12:47.33 |
| | It's just that pdf is the only thing we support writing at the moment. | 12:47.50 |
| tor8 | fz_save_document is a bit vague; I don't think we intend to support writing xps and cbz documents back out because we never intend to edit them | 12:48.14 |
| Robin_Watts | tor8: For now, yes. | 12:48.34 |
| tor8 | the fz_save_options struct is currently very much pdf specific | 12:49.36 |
| Robin_Watts | spots that the guts of fz_output_pcl are commented out. oops. | 12:50.28 |
| | tor8: They express all the concepts that are required for PDF. | 12:51.30 |
| | but it's possible that they may apply to other formats too. | 12:51.51 |
| | but for now, I can't immediately see us wanting to fz_write_document to an fz_output. | 12:52.33 |
| | So, I'd live with what you had in your commit, happily enough. | 12:52.46 |
| tor8 | Robin_Watts: okay, let's leave it at that for now then | 12:54.34 |
| | Forward 1 day (to 2015/12/16)>>> | |
IRC Logs