[gs-code-review] stefan's bittagging patch

[Igor V. Melichev]

The supplied patch includes :

+        /* to distinguish text from vectors we hackly look at the
+           target device 1 bit per component is a cache and this is
+           text else it is a path */

Such check won't work (1) with -dNOCACHE,
(2) with large characters (which are never cached),
(3) with -dTextAlphaBits=2 or 4,
(4) with "(xyz) true charpath stroke".

Besides that, the comment does not correspond to the code,
see the definition :

#define gx_device_has_color(dev)                           \
   ( (dev)->color_info.num_components > 1 ||                \
     (dev)->color_info.gray_index == GX_CINFO_COMP_NO_INDEX )

"1 bit per component" surely must not appear in the comment,
because 1bpc CMYK device satisfies the comment
and does not satisfy the check.

Igor.


----- Original Message ----- 
From: "Ralph Giles" <ralph.giles at artifex.com>
To: <dan.coby at artifex.com>
Cc: <gs-code-review at ghostscript.com>
Sent: Tuesday, August 29, 2006 10:11 AM
Subject: [gs-code-review] stefan's bittagging patch


> Dan,
>
> This is (I hope!) the complete patch for stefan's bittagging work
> from the GhostPCL branch. I've not tested it or resolved the conflict
> with your commit in r6702 as a fix for 688638.
>
> This patch is also missing makefile dependency updates for the new
> headers.
>
> If you want to do that and apply to gs trunk, that would be great. If
> you don't have time let me know and I'll do it.
>
> -r
>
>


--------------------------------------------------------------------------------


> _______________________________________________
> gs-code-review mailing list
> gs-code-review at ghostscript.com
> http://www.ghostscript.com/mailman/listinfo/gs-code-review
>