[gs-code-review] Re: stefan's bittagging patch

[Ralph Giles]

On Tue, Aug 29, 2006 at 04:18:59PM -0700, Dan Coby wrote:

> Since your purpose is bring the GS and PCL branches together, I
> have no objection to making this commit.  Committing this stuff
> is probably the quickest and easiest path toward a single tree.

Great, thanks. I've now committed an updated patch which includes
the relevent makefile updates.

> 1)  I still have to finish 688638 'Make ROPs and overprinting
> compatible'.  This is key to resolving your questions about the
> various map_color_rgb routines.  Obviously this is critical for a
> language switch build which needs to support both PCL ROPs and
> PS/PDF overprinting.  I am bumping this to the top of my queue.

Ok. I didn't test, but assume we probably will have a regression on 
bug 688638 until you get this committed.

> 2)  Someone decided to define gs_bitrgbtags_device with a giant
> structure initialization instead of using the various device
> macros.  I do not know why.  It makes for very fragile code since
> if someone adds a field to the gs_device or gs_prn_device structures,
> then the initialization will fail.

IIRC Stefan had some objection to the macros. I don't know the templates 
well and didn't feel like tracing through to collapse them again. If you 
can do this quickly please do so.

Note that the patch to the jpeg device to add scale and offset support 
did the same thing in r7006.

> Note:  I used the term 'object type' in my code instead of Stefan's
> term 'object tag'.  Stefan's term is probably better since 'object type'
> is too generic.  I will change my nomenclature to match his.

Agreed.

> I suggest that we proceed as follows:
> a)  You commit your patch for Stefan's object tagging.

This is now done, so please go ahead with the rest.

> b)  I modify my custom color processing logic to use Stefan's
> nomenclature and also to include his BITTAG global value.
> c)  I commit my changes which pulls Stefan's version of setting the
> object tag and replaces it with mine.
> d)  I straighten out 688638 and commit this fix.
> 
> I am hopeful that I only have to do my commits to a single tree (gs head).

You can just commit to gs head. I'd only commit to the gs853merge branch 
if it's directly relevent to the language fix build.

If/when do you commit something to the gs853merge branch, please *also* 
commit it to head to limit the divergence in that direction. That helps 
a lot.

Thanks for reviewing,
 -r