[gs-regression] local cluster regression 40bdfff14aa2d3190526f44d4ef81d3c8c65be3f

marcos.woehrmann at artifex.com marcos.woehrmann at artifex.com
Tue Sep 20 14:18:19 UTC 2011


40bdfff Bug #692520 (partial, pdfwrite portion only) fix return testing
------------------------------------------------------------------------
commit 40bdfff14aa2d3190526f44d4ef81d3c8c65be3f
Author: Ken Sharp <ken.sharp at artifex.com>
Date:   Tue Sep 20 09:58:48 2011 +0100

    Bug #692520 (partial, pdfwrite portion only) fix return testing
    
    The cos_c_string_value function returns a pointer (to a parameter passed to it!)
    which is cast to an int and tested for negativity. This is terrible practice.
    On 64- bit machines the pointer doesn't fit into an int and on 32-bit machines it
    will erroneously detect an error if a valid pointer exceeeds 2GB.
    
    The only reason for the test is to allow the funciton call to be included
    in the body of an 'if' test, which is a hideous way of constructing the
    code.
    
    This commit reformats the code, and does away with the irrelevant return code
    test.
    
    No differences expected, this path is not tested by the cluster.

Changed files:
gs/base/gdevpdfc.c

Products tested: gs ls pcl xps 


New warnings:

None

ran 57878 tests in 1876 seconds on 10 nodes

No differences in 46728 non-pdfwrite/ps2write tests

No differences in 6739 pdfwrite tests

No differences in 4411 ps2write tests

The following 4 regression file(s) have started producing errors:
tests_private/comparefiles/Bug690534.pdf.ps.ppmraw.300.0 gs ps2write henrysx6 i7b Timeout_reading_Ghostscript_produced_PDF/PS_File
tests_private/comparefiles/Bug691740.pdf.plank.300.1 gs inches i7b Timeout_reading_input_file
tests_private/comparefiles/Bug691783.pdf.plank.300.1 gs macpro i7 Timeout_reading_input_file
tests_private/customer_tests/01298.pcl.pdf.ppmraw.600.0 pcl pdfwrite meters peeves Timeout_reading_Ghostscript_produced_PDF/PS_File

-------------------------------------------------------------------------------------------------------

The following 9 regression file(s) had differences but matched at least once in the previous 50 runs:
tests_private/comparefiles/Bug691778.ps.plank.300.1 gs meters inches 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/comparefiles/Bug691778.ps.plank.300.1 gs meters inches 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/pcl/pcl5cats/Subset/FH909SC2.BIN.pdf.ppmraw.600.0 pcl pdfwrite inches i7a 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/pcl/pcl5cats/Subset/FH909SC2.BIN.pdf.ppmraw.600.0 pcl pdfwrite inches i7a 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/pcl/pcl5ccet/29-07.BIN.ppmraw.600.1 pcl i7a meters 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/pcl/pcl5efts/fts.2130.pdf.ppmraw.600.0 pcl pdfwrite macpro macpro b3ee2cd07fc7bdfbc3014316f0d4f7da54c900ee 16 
tests_private/pcl/pcl5efts/fts.2291.pbmraw.600.1 pcl macpro macpro 6aa157b438ac69f9732b9f7b29e8570cceb50e8e 5 
tests_private/pdf/PDF_1.7_FTS/fts_17_1703.pdf.cups.300.1 gs i7b x6 13028e7b90dba007183c4b64a5d6b1363e30c993 2 
tests_private/ps/ps3cet/12-08C.PS.psdcmyk.72.0 gs i7b i7b 50d947b5f4801d1042166acbd8b5aed982f57697 4 



More information about the gs-regression mailing list