[gs-regression] local cluster regression fe8d7b6aebfed3c724a860e31ff170764d5429dc

marcos.woehrmann at artifex.com marcos.woehrmann at artifex.com
Wed Sep 28 18:03:42 UTC 2011


fe8d7b6 Fix bug 692372: Add finalize for imager_state to ref_count decrement icc structs.
------------------------------------------------------------------------
commit fe8d7b6aebfed3c724a860e31ff170764d5429dc
Author: Ray Johnston <ray.johnston at artifex.com>
Date:   Thu Aug 18 17:01:43 2011 -0700

    Fix bug 692372: Add finalize for imager_state to ref_count decrement icc structs.
    
    The graphics atates were being freed by the 'alloc_restore_all' done during gs_lib_finit
    but the icc_link_cache was not getting its ref_count decremented, so it never freed the
    semaphore which caused handles to be lost by windows. The rc_gsicc_profile_cache_free
    function is also fixed to save the 'next' pointer to avoid dereferencing freed memory.
    
    Note that we _should_ be able to call gs_imager_state_release to decrement the counts
    of ALL of the elements, but the ref counting of the other elements is _so_ badly
    maintained that some elements (dev_ht and halftone) are prematurely freed by this.
    This change is enough to fix the bug and pass cluster regression.

Changed files:
gs/base/gsicc_profilecache.c
gs/base/gsistate.c
gs/base/gsstate.c
gs/base/gxistate.h
gs/base/gzstate.h

Products tested: gs ls pcl xps 


New warnings:

None


*****************************************************************************
Seg faults with current rev:

tests_private/comparefiles/Bug690676.pdf.psdcmyk.72.0 meters Seg_Fault
tests_private/comparefiles/Bug692217.pdf.pdf.pkmraw.300.0 inches Seg_Fault_reading_Ghostscript_produced_PDF/PS_File
tests_private/comparefiles/Bug692217.pdf.pdf.ppmraw.300.0 inches Seg_Fault_reading_Ghostscript_produced_PDF/PS_File

*****************************************************************************


ran 59517 tests in 2246 seconds on 10 nodes

Differences in 3 of 48054 non-pdfwrite/ps2write test(s):
tests_private/ps/ps3cet/12-07B.PS.cups.300.1 gs meters x6
tests_private/ps/ps3cet/12-07B.PS.pbmraw.300.0 gs meters peeves
tests_private/ps/ps3cet/12-07B.PS.pbmraw.300.1 gs peeves x6

No differences in 6896 pdfwrite tests

No differences in 4567 ps2write tests

The following 9 regression file(s) have started producing errors:
tests_private/comparefiles/Bug689150.pdf.pdf.pkmraw.300.0 gs pdfwrite x6 i7a Timeout_reading_Ghostscript_produced_PDF/PS_File
tests_private/comparefiles/Bug689150.pdf.ps.pkmraw.300.0 gs ps2write i7a henrysx6 Timeout_reading_Ghostscript_produced_PDF/PS_File
tests_private/comparefiles/Bug690676.pdf.plank.300.1 gs inches i7 Timeout_reading_input_file
tests_private/comparefiles/Bug690676.pdf.ppmraw.300.1 gs inches i7 Timeout_reading_input_file
tests_private/comparefiles/Bug692217.pdf.pbmraw.300.1 gs peeves i7b Timeout_reading_input_file
tests_private/comparefiles/Bug692217.pdf.pkmraw.300.1 gs peeves i7a Timeout_reading_input_file
tests_private/comparefiles/Bug692217.pdf.ppmraw.300.1 gs macpro i7 Timeout_reading_input_file
tests_private/comparefiles/Bug692361.pdf.ps.pkmraw.300.0 gs ps2write meters i7a Timeout_reading_Ghostscript_produced_PDF/PS_File
tests_private/customer_tests/01298.pcl.pdf.ppmraw.600.0 pcl pdfwrite x6 i7b Timeout_reading_Ghostscript_produced_PDF/PS_File

The following 2 regression file(s) have stopped producing errors:
tests_private/comparefiles/Bug692361.pdf.pkmraw.300.0 gs i7b peeves Timeout_reading_input_file
tests_private/comparefiles/Bug692361.pdf.pkmraw.300.1 gs i7 inches Timeout_reading_input_file

-------------------------------------------------------------------------------------------------------

The following 20 regression file(s) had differences but matched at least once in the previous 50 runs:
tests_private/comparefiles/Bug692174.pdf.plank.300.1 gs peeves i7 ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692174.pdf.plank.300.1 gs peeves i7 ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692217.pdf.pgmraw.300.0 gs macpro inches f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692217.pdf.pgmraw.300.0 gs macpro inches f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692217.pdf.pgmraw.300.1 gs macpro peeves f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692217.pdf.pgmraw.300.1 gs macpro peeves f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692217.pdf.pkmraw.300.0 gs macpro henrysx6 f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692217.pdf.pkmraw.300.0 gs macpro henrysx6 f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692263.pdf.ps.pkmraw.300.0 gs ps2write peeves i7b ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692263.pdf.ps.pkmraw.300.0 gs ps2write peeves i7b ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692361.pdf.pdf.ppmraw.300.0 gs pdfwrite meters meters ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692361.pdf.pdf.ppmraw.300.0 gs pdfwrite meters meters ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/comparefiles/Bug692361.pdf.ppmraw.300.1 gs meters inches f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692361.pdf.ppmraw.300.1 gs meters inches f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692361.pdf.ps.ppmraw.300.0 gs ps2write macpro macpro f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/comparefiles/Bug692361.pdf.ps.ppmraw.300.0 gs ps2write macpro macpro f97a9171cfb7f1081040a7bd56c4238105e6865a 5 
tests_private/pcl/pcl5ccet/32-01.BIN.pdf.ppmraw.600.0 pcl pdfwrite peeves inches f21756f217abc06b41d09946cffad083c8992ac5 2 
tests_private/pcl/pcl5efts/fts.2291.ppmraw.600.1 pcl macpro macpro 2946424a03da33d2f00d27626c4692f8942f7f04 11 
tests_private/ps/ps3cet/34_all.PS.pgmraw.300.1 gs i7 meters ddf450125929a9c261b3f7f99ec29c8da69b0207 4 
tests_private/ps/ps3cet/34_all.PS.psdcmyk.72.0 gs i7b kilometers ddf450125929a9c261b3f7f99ec29c8da69b0207 4 



More information about the gs-regression mailing list