| <<<Back 1 day (to 2013/06/08) | 2013/06/09 |
robin_watts_mac | tor8: I just pushed an openjpeg fix of michaels. | 01:46.10 |
tor8 | robin_watts_mac: alright. | 01:47.40 |
robin_watts_mac | PCL options changes are on robin/master for your comments if you're feeling bored. | 01:47.49 |
tor8 | robin_watts_mac: I've got a handful of patches on tor/master waiting for review when you're likewise bored :) | 01:48.01 |
robin_watts_mac | we can squash the 2 PCL commits together, but I kept them separate for now to make it easier for you to see what I'd changed. | 01:48.21 |
| will look now. | 01:48.24 |
tor8 | it's the begin/end page stuff | 01:48.35 |
| tor/wip has commits that need discussion whether they should go in or not. I'm not decided on any of them yet. | 01:49.12 |
robin_watts_mac | I looked at the begin/end page one before. | 01:49.52 |
| It all looks fine, except in the display list code you now transform the rect in every case, even though we don't always use it. | 01:50.19 |
tor8 | robin_watts_mac: we use it in the majority of cases | 01:51.05 |
robin_watts_mac | right, majority yes, | 01:51.14 |
| but not all. | 01:51.19 |
tor8 | but if you want the call duplicated to each individual case, I'm not going to fight it | 01:51.30 |
robin_watts_mac | tor8: I'd prefer not to duplicate it, but it's a non-trivial amount of FP. | 01:52.22 |
tor8 | nested switch? | 01:53.02 |
| with the non-using cases in the outer one, and the using cases in an inner switch on the default | 01:53.20 |
| (does that sentence even parse?) | 01:53.33 |
robin_watts_mac | tor8: That might work. | 01:53.34 |
| Or just 2 switches. | 01:53.38 |
tor8 | PCL options look good | 01:54.19 |
robin_watts_mac | Your //XXX line in there; we should test to see whether sane/the cluster show any changes with it regularized. | 01:54.32 |
tor8 | yeah. that one looked wrong, but wanted to ask you for confirmation since you've messed most with the tiles lately | 01:55.20 |
robin_watts_mac | tor8: Should we squash the 2 PCL ones together? I'd vote yes. | 01:55.41 |
tor8 | robin_watts_mac: yes. squash. I like the separate commit for review purposes though, it does help to see what's changed | 01:56.17 |
| but for non-review purposes, squashed is better | 01:56.32 |
robin_watts_mac | First 2 of yours + PCL pushed. | 01:57.54 |
| and now bedtime! | 01:58.23 |
tor8 | sleep tight! | 01:58.35 |
ray_laptop | I made it. Not sure if the elevator made it to 9 or not, however | 02:44.19 |
vtorri | aksr, there is at least a TODO in the code | 08:25.19 |
| see text_search.c | 08:25.28 |
aksr | vtorri: i'm glad to hear ;) ty | 08:27.30 |
sebras | aksr: vtorri: the intent is to fix this by implementing a new GTK+-based viewer instead of the current viewer. | 09:06.34 |
aksr | sebras: ok, but which is current? | 09:07.08 |
sebras | aksr: I assume you are on Linux? I believe that other viewers such as those on Android and iOS might handle non-ASCII input better. | 09:07.25 |
aksr | sebras: Yes, I'm. | 09:07.46 |
sebras | aksr: the currently bundled viewer does not use GTK+, it uses xlib directly as far as I know. | 09:08.06 |
| aksr: implementing your own input methods is unnecessarily difficult, so this is one reason for deciding on some toolkit. | 09:08.42 |
aksr | sebras: OK, I understand. ;) | 09:09.16 |
sebras | aksr: to the best of my knowledge there is as of now no fix plan when the GTK+-based viewer will be ready though. :) | 09:09.30 |
aksr | ..just, I'm not sure why GTK+... | 09:09.32 |
sebras | aksr: the decision was to go for some C-based toolkit which is used a lot, and GTK+ seems to fit this description. | 09:10.35 |
aksr | sebras: I understand, thank you. | 09:11.31 |
| Forward 1 day (to 2013/06/10)>>> | |