| | <<<Back 1 day (to 2016/02/01) | 20160202 |
| sebras | tor8: I have also determined that the margin-calculations done in layout_block() are bogus. consider the case where width:80%;margin-left:10%;margin-right:auto;. in this case because margin-right == auto we will assume that margin[R] == top->w, which does not at all conform to https://www.w3.org/TR/CSS2/visudet.html#blockwidth | 00:51.16 |
| | tor8: I'm debugging 696000, but I have yet to understand this fully enough to make a patch. | 00:51.46 |
| tor8 | sebras: we currently don't handle the width property | 10:39.53 |
| | and we don't handle 'auto' | 10:40.14 |
| sebras | tor8: no, I can see that. to handle both width and auto we'd need some more elaborate calculations in layout_line() | 16:28.00 |
| Robin_Watts | sebras: Fiddling in layout_line may cause conflicts with my shaping commit. | 16:28.52 |
| sebras | Robin_Watts: right, the patch I have now over at sebras/master is just a minor one though. | 16:29.20 |
| | Robin_Watts: supporting width/auto is probably a bigger thing. | 16:29.32 |
| tor8 | sebras: supporting width:auto (and indeed, floating images) is probably the next step to improve epub layout | 16:30.04 |
| Robin_Watts | I'm sure that problems will not be unresolvable. Just warning people that the possibility is there. | 16:31.01 |
| tor8 | Robin_Watts: I'm about to sign out for today, but I've got the java stuff working reliably on desktop | 16:31.35 |
| Robin_Watts | tor8: cool. Got a commit up for that? | 16:31.47 |
| tor8 | piped it through "tor style-filter" while going through all the code checking exception handling | 16:31.55 |
| | now I just need to get the android code back in order and see about getting the android viewer running again | 16:32.16 |
| sebras | tor8: Robin_Watts: so it's better that I stay off looking into these changes for layout_line() for a while, then? | 16:32.21 |
| tor8 | Robin_Watts: it's on tor/jni. you might be better off reading the final result than trying to read the massive diffs. | 16:32.31 |
| Robin_Watts | sebras: No, I'd say keep working. | 16:32.41 |
| sebras | Robin_Watts: alright. | 16:32.50 |
| | tor8: pushed a revised patch to sebras/master. would be nice if it got in. :) | 16:33.04 |
| Robin_Watts | Or... pull in robin/harfbuzz and work on that? | 16:33.17 |
| tor8 | sebras: once I've got the android java stuff back in order I intend to review robin/harfbuzz and get that merged in | 16:33.33 |
| sebras | tor8: I noticed that harfbuzz was built when I updated last night. | 16:34.03 |
| | tor8: so you got it working without g++? | 16:34.12 |
| tor8 | sebras: yeah, the library is built just not used | 16:34.13 |
| | sebras: no, we require c++ for harfbuzz | 16:34.26 |
| sebras | tor8: oh, you cleverly hid it behind CC though... | 16:35.10 |
| | as in "CC build/debug/harfbuzz/hb-ft.o" | 16:35.39 |
| mvrhel_laptop | tor8: I had a couple distractions last week with gsview and the patent search. I am going to get back to mupdf this week | 16:50.13 |
| mvrhel_laptop_ | Robin_Watts: stupid network issue. and #artifex does not like mvrhel_laptop_ | 17:33.58 |
| | so the last I heard is that you had x64 working | 17:34.36 |
| Robin_Watts | Well, hmmph. | 20:16.04 |
| mvrhel_laptop | off to lunch | 20:27.16 |
| | Robin_Watts: I was actually able to get gsview updated with all the changes that have occurred in mupdf | 20:27.33 |
| | it was not too bad | 20:27.35 |
| | Forward 1 day (to 2016/02/03)>>> | |
IRC Logs