| | <<<Back 1 day (to 2016/07/31) | 20160801 |
| sebras | Robin_Watts: ok, so b08617e I'm convinced will solve the issue. | 17:52.38 |
| Robin_Watts | Ta. | 17:52.49 |
| sebras | Robin_Watts: there might be more generic way to resolve it rather than using a flag, but I'm not smart enough to identify it. | 17:53.29 |
| Robin_Watts | sebras: Font stuff tends to be more tor8's domain. | 17:54.00 |
| | I think what I have is safe. He might be able to improve it when he returns. | 17:54.17 |
| sebras | maybe we should be using fz_empty_rect och fz_unit_rect or fz_infinite_rect instead of those made up values in fz_set_font_bbox() | 17:54.34 |
| | Robin_Watts: I agree. | 17:54.43 |
| | och is swedish and means and... what I meant to say was "or"... | 17:55.04 |
| | Robin_Watts: the other one you want reviewed is 6054179? | 17:55.46 |
| Robin_Watts | sebras: I think those values are made up for a deliberate reason. | 17:55.47 |
| | Yes please. | 17:55.56 |
| sebras | Robin_Watts: quite possibly, and those are the reasons that should go in a comment! :) | 17:56.20 |
| Robin_Watts | can't argue with that. | 17:56.43 |
| sebras | (not the silly comments contents I frequently see other people doing.) | 17:56.47 |
| | (in other projects! ;) ) | 17:56.57 |
| | ok so with 6054179 you mess up the comments for the field. I think they were meant to be read "has and FT_FAce if used... substitute metrics ... and stretch to match PDF metrics" etc. | 17:58.41 |
| | Robin_Watts: maybe some newly introduced fields messed up the comments too, I'm not sure. | 18:00.07 |
| Robin_Watts | Hmm. I'm struggling to read the comments in a way that would mean they were now messed up. | 18:02.24 |
| sebras | Robin_Watts: tracing the history of our header files is an interesting journey into merging and splitting and moving betweeen directories... | 18:05.36 |
| Robin_Watts | sebras: Yeah. | 18:06.00 |
| sebras | Robin_Watts: I think what makes me curious is the ... part. | 18:07.56 |
| Robin_Watts | sebras: I think that's just tor for " <--- " | 18:08.13 |
| sebras | Robin_Watts: might be. I interpreted those as being (at one point) connected to the comments above. | 18:09.14 |
| | Robin_Watts: is it better to take the opportunity to rephrase e.g. "... and stretch to match PDF metrics" into "stretch to match PDF metrics"? | 18:09.51 |
| Robin_Watts | sebras: Sure. | 18:10.07 |
| sebras | similarly for the others. | 18:10.14 |
| Robin_Watts | http://git.ghostscript.com/?p=user/robin/mupdf.git;a=commitdiff;h=655ebcece89ace3e103addafa48a3c0a45bd99a1 ? | 18:11.55 |
| sebras | Robin_Watts: what happens if I assign 0xff to one of the bitfields? | 18:12.22 |
| Robin_Watts | sebras: bad things. don't do that. | 18:12.59 |
| sebras | Robin_Watts: because fz_new_font_from_buffer() takes an int use_glyph_bbox which is passed verbatim all the way through to the bitfields. | 18:13.05 |
| | and fz_new_font_from_buffer() is in our public API, no..? | 18:13.18 |
| Robin_Watts | sebras: We should probably use !! more often than we do. | 18:13.34 |
| | font->foo = !!foo; | 18:13.52 |
| sebras | Robin_Watts: indeed. I did check the other bitfield bits for this patch though and it seems ok. | 18:14.13 |
| | Robin_Watts: several were doing the !! trick. | 18:14.21 |
| | Robin_Watts: most simply assigned 0 or 1. | 18:14.32 |
| | Robin_Watts: didn't I review the one about sending svg image data multiple times already? | 18:15.40 |
| Robin_Watts | yes. | 18:15.47 |
| | I'm holding off on it until I work out how I feel about it. | 18:16.13 |
| sebras | Robin_Watts: did I like it? :) | 18:16.13 |
| | Robin_Watts: ah, ok. | 18:16.22 |
| Robin_Watts | sebras: I think so. | 18:16.24 |
| | http://git.ghostscript.com/?p=user/robin/mupdf.git;a=commitdiff;h=b73d7cabcb280ba7625e80978c1789eecd3c8ba4 | 18:16.36 |
| sebras | Robin_Watts: yup, should work perfectly. LGTM. | 18:17.07 |
| Robin_Watts | Thanks. | 18:17.14 |
| sebras | Robin_Watts: any opinions on the ones over at sebras/master? | 18:17.46 |
| | Robin_Watts: I've updated them according to tor8's comments. | 18:18.51 |
| Robin_Watts | lgtm. | 18:20.00 |
| sebras | Robin_Watts: pushed, our patches should keep the cluster busy for the afternoon. | 18:24.50 |
| Robin_Watts | sebras: Ta. | 18:24.59 |
| sebras | Robin_Watts: hey I offered review because I needed it myself. ;) | 18:26.05 |
| sebras | has no ulterior motives... | 18:26.15 |
| Robin_Watts | sebras: Always good to prod me about reviews. I have little functioning memory, so I forget stuff easily. | 18:26.54 |
| sebras | Robin_Watts: no worries. /me sleeps | 18:27.53 |
| Robin_Watts | Night sebras. | 18:43.19 |
| | Forward 1 day (to 2016/08/02)>>> | |
IRC Logs