| | <<<Back 1 day (to 2016/08/23) | 20160824 |
| sebras_ | tor8 (for the logs): ok, so I adressed the comments you had I believe. there's a bunch of commits on sebras/master doing the whole operation in steps. passes through cluster without regressions. | 04:16.29 |
| | tor8 once those are LGTY I'll try to finish up the JNI exception commits. | 04:20.02 |
| | tor8 and then the archive stuff. | 04:20.10 |
| fgdg | fddg | 07:25.34 |
| | hi | 07:25.41 |
| ghostbot | Welcome to #ghostscript, the channel for Ghostscript and MuPDF. If you have a question, please ask it, don't ask to ask it. Do be prepared to wait for a reply as devs will check the logs and reply when they come on line. | 07:25.41 |
| fgdg | [12:56] <fgdg> hi [12:56] <fgdg> how to embedd pkcs data in pdf [12:56] <fgdg> ios [12:58] <fgdg> please share the demo code, sunil.a [12:58] <fgdg> sunil.aruru@gmail.com | 07:28.37 |
| kens | fdgd we don't write code for free users, if you haev a question we can try to answer it. | 07:29.38 |
| | But please don't just quote the logs, the time stamps make it very hard to read | 07:29.57 |
| | Why would you want to 'embed pkcs data' in a PDF file ? | 07:32.01 |
| sebras | tor8: new patches: yey! or ney! ? | 09:25.03 |
| tor8 | sebras: looking now. | 09:28.41 |
| | sebras: 'buffer overflow in pdf_dict_getp' maybe better phrased as 'path too long'? | 09:29.38 |
| | sebras: first 4 commits LGTM | 09:34.43 |
| sebras | tor8: ok, I'll work that change into one of the commits. | 09:35.03 |
| tor8 | the function name is automatically added to the exception message, so no need to mention it | 09:35.29 |
| sebras | probably the one "Turn warnings in dict/array funcs to exceptions. | 09:35.34 |
| tor8 | sebras: yes. | 09:35.42 |
| sebras | actually, the message was already like this. :) | 09:35.49 |
| | but I have no problems with changing it anway. | 09:35.56 |
| tor8 | pdf_dict_dels 'key is null' exception; do we want it? | 09:36.14 |
| sebras | pdf_array_delete() throws if index is out of bounds. | 09:36.50 |
| | couldn't a NULL key in a dict be similar? | 09:37.01 |
| tor8 | sebras: do we throw in pdf_dict_put if the key is null? | 09:37.22 |
| sebras | yes. | 09:37.47 |
| | I test using if (!OBJ_IS_NAME(key)) fz_throw() | 09:38.05 |
| | and if key == NULL then we'll throw. | 09:38.12 |
| tor8 | then let's throw there too | 09:38.26 |
| sebras | if _val_ is == NULL I'll do val = pdf_new_null() though. | 09:38.27 |
| tor8 | I'm looking at the last commit, and wondering what the right thing to do is (create pdf_new_null or not) | 09:39.04 |
| sebras | tor8: I should admit that I haven't tested this in mujs. | 09:39.24 |
| tor8 | sebras: you could just use PDF_OBJ_NULL and not need to call pdf_new_null | 09:39.31 |
| | it's one of the static preallocated objects | 09:39.36 |
| | if (obj == NULL) obj = PDF_OBJ_NULL; | 09:39.51 |
| sebras | true | 09:40.03 |
| | in that case I don't need the doc pointer either! excellent. :) | 09:40.24 |
| tor8 | with those fixes, should be good to go | 09:40.38 |
| sebras | tor8: fixed. I also renamed the new_obj argument in put_drop_val() to be item, just like all other functions. | 09:56.06 |
| chrisl | mvrhel_laptop: do you still need something from me? (I have to head out, but will be working later tonight - my time) | 13:55.23 |
| mvrhel_laptop | chrisl: no I am fine thanks | 13:55.37 |
| kens | mvrhel_laptop : Did you understand what Phil Shipley's point is regarding the Altona test file ? | 13:56.06 |
| chrisl | mvrhel_laptop: okay, cool. I should have something in the next day or so on the iOS Ghostscript front | 13:56.13 |
| mvrhel_laptop | kens: I just sent him an email | 13:56.17 |
| kens | Ah not seen it yet, OK | 13:56.23 |
| mvrhel_laptop | chrisl: well you are ahead of me | 13:56.34 |
| kens | There it is.... | 13:56.35 |
| mvrhel_laptop | chrisl: If I ever get out from under this barrage from Phil..... | 13:56.55 |
| chrisl | mvrhel_laptop: good luck ;-) | 13:57.26 |
| kens | And Zoltan.... | 13:57.31 |
| mvrhel_laptop | yes that too | 13:57.35 |
| | on top of that I have managed to catch a summer-time cold. I swear this thing wont go away | 13:59.06 |
| kens | :-( | 13:59.17 |
| | Spend more time indoors :-) | 13:59.27 |
| mvrhel_laptop | maybe | 13:59.58 |
| sebras | tor8 (for the logs): there is a series of patches over at sebras/master that prepare for the exceptions | 19:05.38 |
| | I'm still having issues with the FIXMEs in "Check arguments and throw suitable exceptions." | 19:06.08 |
| | the problem being that being_mask is being called with cs == NULL and we can't do fz_throw() there as we should be able to (I use the top commit of sebras/wip for testing this) | 19:07.05 |
| | some files in the cluster give issues. | 19:07.17 |
| | this causes me to believe that there might be something else wrong in the color/colorspace-related patches. | 19:07.48 |
| | Forward 1 day (to 2016/08/25)>>> | |
IRC Logs