| | <<<Back 1 day (to 2016/09/08) | 20160909 |
| fredross-perry | sebras: I see you added an "options" parameter to Page.toStructuredText(options). There's no information about what the options are. It would be good to put that in Page.java somewhere. Right now I am passing 0, which seems to not be broken. | 16:23.41 |
| tor8 | fredross-perry: the options argument is a bit mask, but I don't think the enums have been added to the java source | 16:26.32 |
| | FZ_STEXT_PRESERVE_WHITESPACE and FZ_STEXT_PRESERVE_LIGATURES | 16:26.42 |
| fredross-perry | tor8: thanks. | 16:28.24 |
| | tor8, sebras: I would like to see the Java sources be as self-documenting as possible, that is, don't rely on the caller's (possible) knowlege of mupdf internals. | 16:29.33 |
| tor8 | fredross-perry: yes. that is a potential blind spot for me though. if you find any bad spots where internal details leak through the interface please do speak up. | 16:31.42 |
| | fredross-perry: I think we may need to change how documents are created to allow for subclassing, and use a static factory method rather than constructors | 16:32.15 |
| | doc = Document.openDocument(filename) instead of doc = new Document(filename) | 16:32.34 |
| | so that the JNI code can instantiate the correct subclass for PDFDocument | 16:33.01 |
| fredross-perry | tor8, sebras: I think I miused the word "internals" here. We should just add FZ_STEXT_PRESERVE_WHITESPACE and FZ_STEXT_PRESERVE_LIGATURES to Java so the Java caller can use them. | 16:34.15 |
| | tor8: Document.openDocument(filename) seems good. | 16:35.08 |
| lfam | Greetings! I am working on a distro package of mupdf. Does anyone know which commit of mujs is used for 'thirdparty/mujs' in the mupdf-1.9a release? | 19:15.54 |
| Robin_Watts | lfam: Not offhand, but it'll be easy to tell from the git repo. | 19:18.56 |
| lfam | Okay, it seems to be a4158ae6fff (Fix call stack overflow triggering off-by-one too late.), which is what I had tried. There must be some problem with my build of mujs. I will keep investigating that. | 19:20.36 |
| | Robin_Watts: By the way, there are two bugs recently disclosed in openjpeg, both of which permit execution of arbitrary code. CVE-2016-5157 and CVE-2016-7163. You might want to update your openjpeg fork if you don't already have those fixes. | 19:21.40 |
| | There might be others too. I notice the last commit in the mupdf / openjpeg fork is dated 2014 | 19:22.21 |
| Robin_Watts | lfam: Thanks. | 19:39.44 |
| | Forward 1 day (to 2016/09/10)>>> | |
IRC Logs