| | <<<Back 1 day (to 2016/10/01) | 20161002 |
| tor8 | RobinWattsLenovo: comments are good to go. the font privatization thing could do with some thinking if we can improve the naming. | 00:01.38 |
| | simplify type3 up to fz_process_shade is also LGTM | 00:02.39 |
| | haven't looked at the ones after that | 00:02.48 |
| | not a fan of "fz_colorspace_n()" naming | 00:03.42 |
| RobinWattsLenovo | ok, let me see if I can rebase that into a reasonable order. | 00:07.57 |
| tor8 | if not we can think about and fix up the names later. | 00:08.30 |
| RobinWattsLenovo | fz_colorspace_components ? | 00:08.35 |
| | yeah, rebasing around the font privatisation is going to be hard. | 00:09.19 |
| tor8 | we can redo the names. I'm more concerned about whether to pass or not pass the context argument. | 00:11.06 |
| | I think, for consistency, and in case we do funkier stuff with subclassing later, we ought to pass it | 00:11.25 |
| | we can redo the names *later*. | 00:11.51 |
| RobinWattsLenovo | ok. | 00:13.45 |
| | I will rejig to add contexts. | 00:13.55 |
| | Does the fix in 697177 seem reasonable? | 00:16.33 |
| | I lack the required understanding. | 00:16.47 |
| tor8 | I'm unsure, I'll need to spend some quality time with the sample file trying to figure out the root cause since I worry that it might be something else I've misunderstood about how the code works. | 00:19.11 |
| | it looks like the weather's letting up somewhat. the gurgling has stopped! | 00:24.02 |
| kens | Shall we meet in the lobby in 5 ? | 00:25.09 |
| RobinWattsLenovo | ok. | 00:26.19 |
| tor8 | ok. | 00:26.31 |
| gentis | when setting HAVE_MUJS := no in the Makethird file, I expexted to be able to compile mupdf without javascript support but I get errors about missing mujs referrencs | 05:04.55 |
| | like this: build/release/libmupdf.a(pdf-xref.o): In function `pdf_close_document': pdf-xref.c:(.text+0x75e): undefined reference to `pdf_drop_js' collect2: error: ld returned 1 exit status make: *** [Makefile:256: build/release/mutool] Error 1 | 05:05.11 |
| | found the nojs error: in pdf-js-none.c pdf_drop_js is missing although it is included in the javascript.h file | 05:32.03 |
| | after edding the emptt implementation it works | 05:32.19 |
| | should I open a bug for this? | 05:32.30 |
| | Forward 1 day (to 2016/10/03)>>> | |
Log of #ghostscript at irc.freenode.net.