| | <<<Back 1 day (to 2016/10/18) | 20161019 |
| sebras | tor8: morning! | 10:24.46 |
| | tor8: the FZ_IMAGE_patch over at tor/master LGTM. | 10:25.53 |
| tor8 | sebras: morning. | 10:32.30 |
| | thanks. did robin check your recent commits? | 10:33.07 |
| sebras | tor8: not yet. I'm looking at yours. | 10:34.03 |
| | what is your pdf_add_image() trying to resolve? | 10:34.15 |
| | tor8: "robustly", ok... how? :) | 10:34.31 |
| tor8 | used to be if we got unknown image types we'd end up in the wrong branch | 10:35.46 |
| | and not decode them, nor create the magic keys | 10:35.53 |
| | like FZ_IMAGE_GIF | 10:36.09 |
| | we'd write a compressed gif but pretend it was uncompressed data | 10:36.22 |
| sebras | ah. | 10:36.24 |
| tor8 | I also shuffled the code around a bit for easier error recovery | 10:36.51 |
| sebras | tor8: also i like that you're moving code outside fz_try(). | 10:36.54 |
| | exactly. | 10:37.01 |
| | tor8: why is FZ_IMAGE_UNKNOWN treated as FZ_IMAGE_RAW? | 10:38.14 |
| tor8 | for the case when we have no compressed buffer image | 10:40.21 |
| sebras | tor8: should the subsampling comment be a FIXME? | 10:40.27 |
| tor8 | cp ? cp->type : FZ_IMAGE_UNKNOWN | 10:40.30 |
| sebras | tor8: so it's easier to find. | 10:40.33 |
| | ah... there! :) | 10:40.36 |
| tor8 | it could be a TODO, but that comment is unchanged from before | 10:41.13 |
| | it's a very low priority IMO | 10:41.22 |
| | but it is an option we could consider eventually | 10:41.32 |
| | right now we don't even have a concept of a destination resolution when writing pdf files | 10:41.49 |
| sebras | right. | 10:43.57 |
| | I like the comma expression in the if-statement. | 10:44.05 |
| | that was a bit unexpected. :0 | 10:44.11 |
| tor8 | sebras: where? (I remember seeing comma expressions in if statements, but I thought that commit had already gone live) | 10:45.41 |
| sebras | if (mod == 0) s++, mod = n; | 10:48.46 |
| tor8 | ah, I thought you meant if-statement expression | 10:50.42 |
| sebras | tor8: s/xps_lookup_link_target/xps_resolve_link/ ? makes it easier to guess the documents function pointer. | 10:53.03 |
| tor8 | sebras: that commit isn't entirely ready yet | 10:53.20 |
| | there are issues with requiring the fz_document argument to resolve_link | 10:53.31 |
| | from JNI you don't have access to the fz_document when doing stuff with page.loadLinks | 10:54.07 |
| | I'm also more inclined to s/resolve_link/lookup_link_target/ | 10:54.39 |
| | sebras: is it just me or is mupdf_native.h out of sync with non-committed changes? | 10:56.20 |
| sebras | tor8: either direction is fine, I'm just a stickler for consistency. but you know that. :) | 10:56.23 |
| | tor8: tell me more about mupdf_native.h? | 10:56.57 |
| | tor8: is there some prototype which is wrong? | 10:57.17 |
| tor8 | it still has PDFObject_toBoolean, should have been changed to PDFObject_asBoolean a long time ago | 10:58.17 |
| | I got diffs when running 'make java' and it regenerated the file | 10:58.29 |
| | sebras: agh. we're not consistent in our internal header filenames | 10:59.11 |
| | foo-imp.h mixed with foo-impl.h | 10:59.16 |
| | our function naming has "imp" so I would prefer sticking with that | 10:59.33 |
| sebras | I don't get any diffs though! | 10:59.48 |
| tor8 | sebras: there's a commit on tor/master | 11:00.08 |
| | delete the file and regenerate it and see what git says? | 11:00.16 |
| sebras | tor8: right... now i see the diffs | 11:00.48 |
| | tor8: I never did this, so that is like why it got out of sync. | 11:01.00 |
| tor8 | it should regenerate every time you run 'make' in the java directory | 11:01.22 |
| sebras | tor8: didn't know I had to, it has seemed to me as if it was automagically updated and so I didn't need to bother to regenerate it manually. | 11:01.36 |
| | tor8: it doesn't for me. :) | 11:01.49 |
| tor8 | it should and does regenerate automatically... for me | 11:01.58 |
| | sebras: time for you to debug makefiles again ;) | 11:02.30 |
| | you might have clock skew or something weird that's not triggering mupdf_native.h dependencies properly | 11:03.02 |
| sebras | tor8: ugh... not tonight. :) | 11:03.04 |
| | tor8: with your commit it looks good though. | 11:03.40 |
| | tor8: did you look at my patches on sebras/master? | 11:03.59 |
| tor8 | sebras: yes. the first four look reasonable to me. | 11:04.56 |
| | the xps-impl.h should probably have some file renaming in it to be consistent | 11:05.08 |
| | of other files than xps as well | 11:05.15 |
| | see my comment above | 11:05.17 |
| sebras | tor8: yeah, I can fix that in a preceeding patch and then just follow the pattern with -imp.h | 11:06.07 |
| tor8 | sebras: going out for lunch. bbl. | 11:06.35 |
| sebras | tor8: ok. when you get back, have a look at the extra -impl.h -> -imp.h patch on sebras/master | 11:21.57 |
| | ehm.. github/master | 11:22.05 |
| jhan | ======== | 12:01.30 |
| | fz_context *ctx; pdf_document *doc; fz_rect rect = {0, 0, 300, 500}; pdf_page *page; pdf_widget *widget; fz_write_options opts = {0}; opts.do_incremental = 1; ctx = fz_new_context (NULL, NULL, 0); doc = pdf_open_document (ctx, filePath); /* Add a new page and create a signature form. */ page = pdf_create_page (ctx, doc, rect, 0, 0); pdf_insert_page (ctx, doc, page, | 12:01.33 |
| | https://we.tl/8GkekGnqcP | 12:03.53 |
| | here is my pdf @robin | 12:04.03 |
| | can you please check and tell what i did wrong | 12:04.17 |
| tor8 | jhan: I assume you mean pdf_add_page rather than pdf_create_page? | 13:05.10 |
| | if not, then you may want to update | 13:09.39 |
| | if yes, then you should NOT be passing NULL for resources and contents | 13:09.56 |
| tej-kweku | any mupdf dev around? | 13:34.27 |
| tor8 | tej-kweku: yes. | 13:36.11 |
| jhan | what is difference between pdf_add_page and pdf_create_page? | 13:36.15 |
| tor8 | pdf_create_page does not exist in the newest version. we have cleaned up the APIs a bit. | 13:36.30 |
| jhan | yes right , | 13:36.46 |
| | but i didn't code how to use pdf_add_page | 13:37.10 |
| | thats why i am using mupdf 1.7 version | 13:37.28 |
| tej-kweku | can mupdf list the table of contents of a pdf, if so how? | 13:37.59 |
| | :windoe | 13:38.20 |
| tor8 | tej-kweku: yes. | 13:38.22 |
| tej-kweku | sorrt | 13:38.24 |
| jhan | but i didn't know the code how to use pdf_add_page@tor8 | 13:38.46 |
| tej-kweku | sorry for the mistakes | 13:38.49 |
| tor8 | from the command line: mutool show foo.pdf outline | 13:38.50 |
| jhan | can please suggest me | 13:38.53 |
| tor8 | tej-kweku: from mupdf-gl: press the 'o' key | 13:39.12 |
| | jhan: look at source/tools/pdfcreate.c for an example | 13:39.28 |
| tej-kweku | I get an error like object out of range (0 0 R); | 13:41.03 |
| kens | object 0 is defined as free, so '0 0 R' is illegal | 13:41.22 |
| tor8 | hm, that sounds like a bad pdf file | 13:41.22 |
| tej-kweku | But the toc appears when I use other pdf readers | 13:42.18 |
| kens | That doesn't make it a legal PDF file | 13:42.30 |
| tor8 | tej-kweku: link the pdf file and I can take a look | 13:42.38 |
| kens | If you'd like to share the file we coulds perhaps comment on it | 13:42.41 |
| tor8 | brb, need to pop out for a couple of minutes | 13:42.45 |
| tej-kweku | kinda new to irc, how can I link the file, it is actually a book | 13:43.13 |
| kens | Put it on dropbox or something similar and post the URL here | 13:43.30 |
| tej-kweku | url: it-ebooks.info/book/2327/ | 13:44.42 |
| kens | That says 'downloading is temporarily unavailable' for me | 13:45.44 |
| tej-kweku | okay just a moment | 13:48.12 |
| | new link: http://www.4shared.com/web/preview/pdf/V-SmKa6xce? | 13:53.28 |
| kens | Seems to want me to sign in with a social media account. I don;t have any | 13:54.46 |
| tej-kweku | okay search fofr Pro PHP MVC on 4shared | 13:55.45 |
| | the file was uploaded a few minutes ago | 13:56.01 |
| kens | Yeah I can see the file, but the site wants my social media accounts (I have none) or want to install browser extensions (not happening) | 13:56.33 |
| | Can't find any way to download hte file which doesn't involve me installing software from the site. I'm not doing that. | 13:58.18 |
| | Just put it on dropbox | 13:58.24 |
| tej-kweku | would have to drop out for a moment | 13:59.21 |
| tor8 | tej-kweku_: mupdf-gl is one of the mupdf viewers for linux and windows | 14:30.13 |
| tej-kweku__ | does not look like mupdf-gl is in debian´s repos | 14:36.03 |
| tej-kweku | is there any source I an get mupdf-gl for debian? | 15:03.04 |
| tor8 | tej-kweku: get it from the git | 15:03.50 |
| tej-kweku | the link | 15:04.49 |
| kens | Its a Git repository git.ghostscript.com/mupdf.git | 15:12.25 |
| tej-kweku | cannot clone, username is being requested | 15:18.11 |
| kens | Anonymous ought to work | 15:19.18 |
| | But I am not a Git expert | 15:19.25 |
| tej-kweku | using "git clone https://github.com/ghostscript/mupdf.git" | 15:20.23 |
| kens | Well that's a mirror I think | 15:21.01 |
| tor8 | tej-kweku: instructions for cloning from git are on mupdf.com | 15:23.08 |
| kens | http://www.mupdf.com/ | 15:24.45 |
| | And then look for Download and that has hte git command | 15:24.55 |
| tej-kweku | okay, thank it worked | 15:26.55 |
| | Forward 1 day (to 2016/10/20)>>> | |
Log of #ghostscript at irc.freenode.net.