| | <<<Back 1 day (to 2016/10/25) | 20161026 |
| tor8 | sebras: options = js_isdefined() ? js_tostring() : NULL ... should probably be using js_iscoercible() instead of isdefined | 11:18.28 |
| | iscoercible returns false on both null and undefined | 11:18.45 |
| sebras | tor8: then the same goes for writer options, right..? | 13:50.34 |
| | I was inspired by that code... | 13:51.49 |
| | Tor8: in ffi_PDFDocument_save() | 13:54.48 |
| tor8 | sebras: yes, probably | 13:59.28 |
| | js_iscoercible is a new addition to mujs, so I haven't changed everywhere that should be using it yet | 14:00.16 |
| | sebras: you still around? | 14:19.32 |
| sebras | tor8yes | 14:20.07 |
| tor8 | your changes look good to me, with that exception of js_iscoercible | 14:20.27 |
| | (the name comes from being a value you can coerce to an Object) | 14:20.44 |
| | all values except null and undefined can be converted to JS objects | 14:20.58 |
| sebras_ | tor8: um... and the argument index? | 14:30.11 |
| tor8 | ? | 14:30.30 |
| sebras_ | tor8: I think it is wrong in my patches. | 14:30.40 |
| tor8 | yes, that too | 14:31.02 |
| | "Common structured text output options:" should that be simply "Structured text output options:"? | 14:32.02 |
| | nothing common about them :) | 14:32.10 |
| sebras_ | tor8: ok.. new set of patches online. | 14:36.57 |
| tor8 | sebras_, sebbras, sebras: LGTM. | 14:40.44 |
| sebras | tor8: :) | 14:40.50 |
| | tor8: I was on mobile before, then I used kens' keyboard when changing my nick... | 14:41.14 |
| kens | Not a good idea.... | 14:41.35 |
| sebras | kens: it's a mcirosoft natural keyboard, is it not..? | 14:42.24 |
| kens | Stil not at the moment | 14:42.44 |
| | Still using bluetoogh clattery keyboard | 14:42.55 |
| | Blutooth* | 14:43.04 |
| tor8 | sebras: now the question is how much on tor/master should go in before the release | 14:47.33 |
| | the link destination handling, yes or no...? | 14:47.44 |
| sebras | tor8: let me glance at it. | 14:47.54 |
| tor8 | sebras: ah, mupdf_native.c needs to be updated for the options | 14:48.19 |
| | to stext | 14:48.23 |
| | and possibly the iOS/android viewers too | 14:48.33 |
| sebras | tor8: I pushed one minute ago. | 14:48.35 |
| | tor8: will you revert? | 14:48.41 |
| | tor8: or separate patch? | 14:48.49 |
| tor8 | separate patch is fine by me | 14:48.57 |
| sebras | tor8: the link dest changes are API changes right, | 14:49.52 |
| | no, rendering changes. | 14:49.57 |
| tor8 | API changes, should not affect rendering at all | 14:50.11 |
| | but will affect all viewers | 14:50.19 |
| sebras | tor8: are those changes trivial? | 14:50.52 |
| | tor8: (like I'm hoping my options changes are going to be in 5min) | 14:51.07 |
| tor8 | I've updated the ones I can test locally, but they break the iOS viewer and android so it may be best to hold off on that | 14:51.24 |
| sebras | tor8: right. | 14:51.41 |
| | tor8: but tor/master up to and including the 1.10 version number lgtm. just let me fix the mess I pushed first though. :-/ | 14:52.17 |
| | tor8: single patch on sebras/master | 15:28.41 |
| | tor8: I'm unable to verify my ios changes, but they look benign. | 15:28.55 |
| | it clusters. | 15:34.49 |
| tor8 | sebras: maybe we should add toStructuredText() { toStructuredText(null); } to the java classes? | 15:37.24 |
| | but the commit LGTM as is | 15:37.45 |
| | that can be a separate addition | 15:37.48 |
| sebras | tor8: so this means we are ready for 1.10..? | 15:53.22 |
| Robin_Watts | Ship it. | 15:54.41 |
| tor8 | sebras: yes, just got to push my commits up to the 1.10 version bump | 16:46.25 |
| sebras | q/uit | 18:03.38 |
| | qu/it | 18:03.42 |
| | qui/t | 18:03.48 |
| | quit/ | 18:03.50 |
| malc_ | wow | 18:27.56 |
| | Forward 1 day (to 2016/10/27)>>> | |
Log of #ghostscript at irc.freenode.net.