| | <<<Back 1 day (to 2018/07/13) | 20180714 |
| sebras | kens: hi! | 09:57.37 |
| kens | Morning sebras | 09:57.45 |
| sebras | kens: I just logged in and saw that you mailed me and created the patch. | 09:57.48 |
| | let me read the last mail.. | 09:57.51 |
| kens | Yeah but I think its too MS-specific | 09:57.59 |
| sebras | yes, I was going to ask about the i32 suffix. | 09:58.10 |
| kens | I think you should probably replace it with something cribbed from the MuPDF sources | 09:58.12 |
| | That only seems to define INT32_MAX but you cna use the same idea to make INT32_MIN | 09:58.35 |
| | I didn't notice originally the i32 suffix :-( | 09:59.00 |
| | I wasn't sure you'd be working over the weekend so I stuck something in to fix it real quick | 09:59.32 |
| sebras | that makes sense. | 10:12.40 |
| | I was just logging in to try to fix it so I didn't mess things up for others... | 10:12.53 |
| kens | Feel free to go ahead and fix it properly :) | 10:13.34 |
| sebras | kens: what do you think about something like this? https://pastebin.com/raw/85C2q4qP | 10:13.36 |
| kens | Yeah that looks better | 10:13.52 |
| sebras | kens: do you mind testing this? | 10:14.00 |
| kens | OK one second | 10:14.17 |
| sebras | kens: I think this ought to work equally well. | 10:14.38 |
| | kens: I'm just copying http://git.ghostscript.com/?p=mupdf.git;a=blob;f=source/fitz/unzip.c;hb=fe8b5f202600e5a328e58222a451ec61dad38875#l8 | 10:15.50 |
| kens | It builds OK on VS 2008. Yes that was what Tor found on Friday I think | 10:16.18 |
| | Obviously a build test is all I can do, but I think that's OK | 10:17.02 |
| sebras | kens: OTOH gs already does http://git.ghostscript.com/?p=ghostpdl.git;a=blob;f=base/gssprintf.c;h=49f54bd42aa6e44b489041bbb7215be38adbc473;hb=HEAD#l74 I guess it only matters what base you prefere to read in. :) | 10:17.08 |
| kens | Functionally the same I guess | 10:17.32 |
| | sebras : I need to head out now. Have a good weekend | 10:21.11 |
| sebras | I'll submit the patch ok? | 10:21.20 |
| kens | Sure yes | 10:21.24 |
| | Please do | 10:21.28 |
| sebras | cool, thanks. and sorry for breaking it:) | 10:21.34 |
| kens | NP At least it was an easy fix :) | 10:21.45 |
| | Bye for now | 10:21.48 |
| sebras | bye! | 10:21.52 |
| | Forward 1 day (to 2018/07/15)>>> | |
Log of #ghostscript at irc.freenode.net.