| | <<<Back 1 day (to 2017/06/09) | 20170610 |
| sebras | Robin_Watts: I looked at "Ensure TIFF images have the correct colorspace." and I'm puzzled by the fact that this affects only fz_load_tiff_info_subimage() and not includes fz_load_tiff_subimage(). is this correct? | 05:24.29 |
| Robin_Watts | sebras: I believe so. | 07:58.25 |
| | fz_load_tiff_subimage is doing the right thing anyway, because of what happens in fz_ensure_additive (or something like that). | 07:59.03 |
| | Indeed, the problem came about specifically because one was doing something, and the other wasn't. | 07:59.23 |
| sebras | Robin_Watts: aha, I wasn't aware that fz_ensure_pixmap_is_additive() actually replaced the colorspace. I see. | 12:56.38 |
| | Robin_Watts: in that case I believe we could put that commit on master as it seems unrelated to the cms stuff. | 12:57.21 |
| | if we want. | 12:57.24 |
| | tor8 (for the logs): I reviewed tor/master and adressed the omissions I noticed, have a look at sebras/master | 16:08.02 |
| | tor8: oh and I tested with sebras/master in -mini and it worked. | 16:14.56 |
| | so if you are happy with my updates, then LGTM. | 16:17.32 |
| | Forward 1 day (to 2017/06/11)>>> | |
Log of #mupdf at irc.freenode.net.