| | <<<Back 1 day (to 2017/07/29) | 20170730 |
| sebras | Robin_Watts: are you about? | 11:15.22 |
| | I'd like to talk a bit about the leak bug we got. | 11:15.50 |
| | I've got. | 11:15.52 |
| | I tried the code in ASAN, memento and valgrind. none detect any memory leak after rendering pdfref17.pdf. | 11:21.17 |
| Robin_Watts | hi. | 11:28.59 |
| | Did you try his code? | 11:29.13 |
| | (or at least look at it to see if you could spot any obvious problems?_ | 11:29.32 |
| sebras | yes I did. and I can't see that there is any leak (unless there is an exception, and I know there isn't) | 11:30.35 |
| | I'm just about to retest on 1.11, maybe we fixed it recently! | 11:30.45 |
| Robin_Watts | sebras: That's possible. | 11:31.00 |
| sebras | yeah, that's it. | 11:31.29 |
| | I see a leak in ASAN and memento back in 1.11 | 11:31.40 |
| | I should have tested this before bothering you. :) | 11:31.51 |
| Robin_Watts | no worries. So he'd probably like a patch for 1.11 if possible. | 11:32.38 |
| sebras | is bisecting | 11:33.18 |
| | Robin_Watts: how do we distribute things like this though? | 11:33.30 |
| | Robin_Watts: do we do special builds? | 11:33.35 |
| | Robin_Watts: or just supply a git format-patch?! | 11:33.48 |
| Robin_Watts | We do not supply builds. | 11:33.58 |
| | A git-format patch (or even a non git format patch) should be fine. | 11:34.12 |
| | If the commit applies directly, then just a pointer to the relavent commit may be enough. | 11:34.46 |
| | Cody seems on the ball. | 11:34.49 |
| | (oops, public channel - just as well I was being complimentary) | 11:35.19 |
| sebras | Robin_Watts: ok, in that case I'll also mention the leak which is in his example code if there is an exception (he might have similar stuff in his real code) | 11:35.35 |
| | Robin_Watts: ok, so 181b2b135ce6527aa8a86da9bd0cdf41c2f68ca9 fixed the leak, I assume that this means I can close 698268? | 11:54.44 |
| | I'll just go along and do that and hope that someone corrects me if I've done something wrong. :) | 11:57.17 |
| Robin_Watts | sebras: sounds good. | 12:02.20 |
| sebras | Robin_Watts: I hope the e-mail I just sent seems reasonable too. | 12:10.53 |
| | Robin_Watts: except I forgot to use the correct sender address, oh well. | 12:11.42 |
| | Forward 1 day (to 2017/07/31)>>> | |
Log of #mupdf at irc.freenode.net.