| | <<<Back 1 day (to 2017/09/12) | 20170913 |
| ktcer | hello | 02:49.13 |
| mubot | Welcome to #mupdf, the channel for MuPDF. If you have a question, please ask it, don't ask to ask it. Do be prepared to wait for a reply as devs will check the logs and reply when they come on line. | 02:49.13 |
| ktcer | use demo error mupdf-android-viewer-old/libmupdf/platform/java/mupdf_native.c:8831: undefined reference to `fz_get_separation' | 02:49.41 |
| | How to solve? | 02:52.07 |
| | There is no such method | 02:52.52 |
| JDoutt | Using Mutool with the clean option on single pdf files. Is there a way to batch an entire folder? | 14:47.09 |
| kens | shell script for one way | 14:47.38 |
| JDoutt | That is what I'll do, thank you. I tried -r to see if that was built in but could not get it to work. | 14:49.21 |
| Piedro | Hi, guys! | 18:06.27 |
| | What's the reason behind GLFW_MUPDF_FIXES ? | 18:06.37 |
| | platform/gl/gl-main.c:1344 | 18:07.37 |
| | When compiled with it ENTER stops working when searching. | 18:08.05 |
| sebras | Piedro: seems to come from this commit: http://git.ghostscript.com/?p=mupdf.git;a=commitdiff;h=32d57390d9de2f9d9bdf55823038fea7fde4bc3f | 18:34.09 |
| | Piedro: but I'm not sure what tor's intent was with this patch. | 18:35.14 |
| | Piedro: oh, are you compiling using the bundled thirdparty/glfw? | 18:37.15 |
| Piedro | yep | 18:37.26 |
| | That's breaking things. | 18:37.40 |
| sebras | Piedro: hm, I was hoping that you didn't because thirdparty/glfw/include/GLFW/glfw3.h should be setting GLFW_MUPDF_FIXES to 1 | 18:38.04 |
| Piedro | Yeah, I also figured it out) | 18:38.24 |
| sebras | seems like this might be local tweaks we've done to glfw. | 18:38.26 |
| Piedro | It's strange that you have no comments on while some keys got excluded. | 18:39.19 |
| | And by the way, could you check this PR? | 18:40.04 |
| | https://github.com/ArtifexSoftware/mupdf/pull/1 | 18:40.06 |
| sebras | Piedro: so is there a commit where compiling where ENTER worked for you? | 18:42.33 |
| Piedro | Nope | 18:43.11 |
| | I can make PR with it. | 18:43.21 |
| sebras | Piedro: also what do you mean by does not work? after starting mupdf-gl with a file, what do yo do next? | 18:43.31 |
| Piedro | It's just deleting this conditions. | 18:43.43 |
| sebras | Piedro: well, this condition appears to be there for a reason. | 18:43.53 |
| Piedro | @sebras: I'm just doing this: "/word<Enter>" | 18:44.32 |
| sebras | Piedro: as I understand it we have fixes in thirdparty/glfw which are not in the normal glfw-distribution and this ifdef is there to make mupdf-gl be able to compile regardless of which one is used. | 18:44.36 |
| | Piedro: I just compiled from a clean repository and it works fine for me. | 18:45.41 |
| Piedro | @sebras: I've just made a grep for GLFW_MUPDF_FIXES, and there's only 2 usages of it. | 18:45.47 |
| | platform/gl/gl-main.c:1357:#ifndef GLFW_MUPDF_FIXES | 18:45.57 |
| | thirdparty/glfw/include/GLFW/glfw3.h:36:#define GLFW_MUPDF_FIXES 1 | 18:46.03 |
| sebras | Piedro: that seems about right. | 18:46.15 |
| Piedro | @sebras: It seems like you compiled not with thirdparty/glfw | 18:46.31 |
| sebras | Piedro: I am using thirdparty/glfw, I know this because if I remove thirdparty/glfw/include/GLFW/glfw3.h then it doesn't compile (also on my system libglfw3-dev is not installed | 18:48.32 |
| | Piedro: could it be that on your system you _do_ have it installed and mupdf for some reason decides to compile using the headers in /usr/include instead of in thirdparty? | 18:49.02 |
| | Piedro: that would explain the errors you are seeing. | 18:49.23 |
| Piedro | But wait. | 18:49.51 |
| | If compiler uses system includes, where GLFW_MUPDF_FIXES not even defined, then how deleting "#ifndef GLFW_MUPDF_FIXES" helps to solve my problem? | 18:51.08 |
| | Also created another PR, have a look. | 18:52.29 |
| | https://github.com/ArtifexSoftware/mupdf/pull/2 | 18:52.30 |
| | I think you mistook #ifndef with #ifdef | 18:58.24 |
| | @sebras: Because #ifndef applies code when symbol is NOT defined. | 18:59.00 |
| | sebras: And #ifndef IS used in platform/gl/gl-main.c:1357 | 18:59.44 |
| sebras | Piedro: yes, I know. | 19:00.13 |
| | Piedro: to me it also seems like it should if #ifdef, but why does it work for me in that case? hm. | 19:05.47 |
| Piedro | sebras: I suppose you somehow have GLFW_MUPDF_FIXES undefined somewhere) | 19:06.50 |
| sebras | Piedro: even so enter works fine here. | 19:07.28 |
| Piedro | sebras: Try to delete this condition with all it contains, then compile and check. | 19:08.11 |
| | sebras: If it still works, there some another issue, if it doesn't, then obviously GLFW_MUPDF_FIXES is not defined. | 19:08.45 |
| sebras | Piedro: surprisingly forc | 19:15.08 |
| Piedro | fug)) | 19:16.05 |
| | sebras: forc you mean works? | 19:18.36 |
| sebras | Piedro: it works for me regardless of whether this code is included or not, presumably because the on_char() and on_key() callbacks are both called for enter. | 19:27.47 |
| | Piedro: what windowing manage are you under? X11? maybe the glfw framework handles key input differently on different platforms. | 19:28.22 |
| Piedro | sebras: Dunno what MacOS uses... | 19:30.04 |
| | Forward 1 day (to 2017/09/14)>>> | |
Log of #mupdf at irc.freenode.net.