| | <<<Back 1 day (to 2017/10/11) | 20171012 |
| sebras | tor8: we should be here... | 13:04.58 |
| | tor8: LGTM upto and including 7fda9815 0b3ecb6e Don't cache page count in pdf_document. on tor/master | 13:05.24 |
| | tor8: how do you feel about sebras/for-robin-master ? | 13:05.47 |
| tor8 | sebras: thanks. | 13:10.20 |
| | sebras: what about the consts in luratech and jpegxr? | 13:11.11 |
| sebras | tor8: forgot about luratech | 13:11.28 |
| tor8 | sebras: the zalloc stuff looks appropriate | 13:12.27 |
| | robin/master minus the WIP look good to me as well | 13:12.48 |
| sebras | something like https://pastebin.com/raw/Nj9KJ4ng is still needed for jpegxr | 13:13.17 |
| | luratech worked fine. | 13:14.25 |
| tor8 | yeah, I just tested luratech and it looks like it works :) | 13:14.48 |
| | sebras: thanks. with that patch the jpegxr stuff builds too. | 13:17.46 |
| sebras | s/too/without warnings &/ | 13:18.24 |
| tor8 | sebras: yes. | 13:18.39 |
| | I'll take that as a final LGTM | 13:18.54 |
| vtorri | tor8: hello | 13:19.02 |
| tor8 | vtorri: hi. | 13:19.11 |
| vtorri | tor8: have you fixed glfw on Windows ? | 13:19.14 |
| | tor8: at least with the last release of mupdf, I have to pass HAVE_GLFW=no | 13:19.50 |
| tor8 | vtorri: it works for me with the visual studio project. | 13:21.20 |
| | vtorri: it also works for me with linux and macosx. | 13:21.35 |
| | so I'm not sure what you mean by "fixed glfw on Windows" | 13:21.51 |
| vtorri | tor8: i'm going to try with msys2 + mingw-w64 | 13:21.53 |
| tor8 | our makefile doesn't support building GLFW on windows. we don't use make with windows much. | 13:22.30 |
| Robin_Watts | vtorri: You mean "fixed glfw with msys2", not "fixed glfw with windows". | 13:22.50 |
| vtorri | tor8: well you told me that you didn't managed glfw on windows and that i had to pass HAVE_GLFW=no to make | 13:23.07 |
| tor8 | you'll need to add another ifeq "$(OS)" "MINGW" section to Makethird for GLFW | 13:23.15 |
| Robin_Watts | You should realise that msys2 is a very niche environment, and not typical windows at all. | 13:23.27 |
| vtorri | Robin_Watts: ok | 13:23.36 |
| | Robin_Watts: i know | 13:23.50 |
| | my students use VS | 13:24.58 |
| | but i have a very good reason to use msys2 + mingw | 13:25.17 |
| | tor8: i'll see if i can work it out | 13:25.28 |
| tor8 | vtorri: https://pastebin.com/raw/y1V21qKa something like that patch, but fleshed out to include the right files and libs (the bits I marked with XXX) should make it work | 13:25.56 |
| vtorri | tor8: thank you | 13:26.59 |
| | hmm | 13:32.03 |
| | so with msys2 + mingw : | 13:32.13 |
| | source/fitz/color-lcms.c:2:22: fatal error: lcms2art.h: No such file or directory | 13:32.14 |
| Robin_Watts | git submodule update --init | 13:33.01 |
| vtorri | i have cloned http://git.ghostscript.com/mupdf.git | 13:33.03 |
| | ha | 13:33.06 |
| | that is new :) | 13:33.26 |
| sebras | tor8: Robin_Watts: LGTM on sebras/master? | 13:46.00 |
| | tor8: oh, and yes you got LGTM before, feel free to push before me. :) | 13:46.21 |
| vtorri | tor8: i have something that works more or less, only one link error : build/release/platform/gl/gl-main.o:gl-main.c:(.text.startup.main+0x288): undefined reference to `win_install' | 13:56.12 |
| | tor8: something to do for the platform code | 13:56.27 |
| sebras | vtorri: that symbol is in platform/gl/gl-win32.c | 13:56.55 |
| vtorri | sebras: i know, it's just that there may be something to add to Makefile but i don't know what yet | 13:57.21 |
| | find . -name 'gl-win32.c' | 13:58.26 |
| | oups | 13:58.30 |
| sebras | vtorri: ./platform/gl/gl-win32.c | 13:58.44 |
| vtorri | ok, Make* are not using that file | 13:59.37 |
| | i just don't know what to do | 13:59.50 |
| sebras | vtorri: that file is used by the visual studio project, see git grep gl-win32 | 14:00.19 |
| vtorri | yes, just did that | 14:00.29 |
| sebras | vtorri: and the call to win_install in gl-main.c is only included if _WIN32 | 14:00.38 |
| vtorri | but i don't know how to change the Make* files | 14:00.45 |
| sebras | vtorri: you could try adding gl-win32 to MUVIEW_GLFW_OBJ in Makefile just to see if it builds for you. | 14:01.32 |
| | it might not be the proper way of doing it, and I haven't looked at the pastbin-thingy that tor8 mentioned before. | 14:01.52 |
| tor8 | you can include it in Makefile | 14:03.19 |
| | ifeq "$(OS)" "MINGW" | 14:03.21 |
| | MUVIEW_GLFW_OBJ += $(addprefix $(OUT)/platform/gl/, gl-win32.o) | 14:03.21 |
| | endif | 14:03.21 |
| vtorri | i still need to pass -DUNICODE | 14:03.39 |
| tor8 | vtorri: you need to edit the Makethird line with $(CC_CMD) -D_GLFW_WIN32_XXX to whatever glfw for windows needs to build with msys2 | 14:04.35 |
| vtorri | tor8: i did that | 14:07.14 |
| | tor8: http://codepad.org/faonw8k2 | 14:08.18 |
| tor8 | vtorri: and that works? | 14:09.07 |
| vtorri | no | 14:10.30 |
| | i need to pass -DUNICODE to gl code | 14:10.44 |
| tor8 | which gl code? | 14:10.56 |
| vtorri | is there a way to pass that to the preprocessor only for platform/gl code ? | 14:11.09 |
| tor8 | to GLFW or the stuff in platform/gl/? | 14:11.10 |
| vtorri | yes | 14:11.14 |
| | ho | 14:11.19 |
| | platform/gl | 14:11.22 |
| tor8 | why does that need -DUNICODE? | 14:11.58 |
| | platform/gl/gl-win32.c uses the W and A suffixed windows functions, so that doesn't need it | 14:12.25 |
| vtorri | because mingw, by default, use multibyte API, contrary to VS | 14:12.46 |
| | https://thepasteb.in/p/y8h65QvxQY0IO | 14:13.26 |
| tor8 | we don't use the default functions... we call GetModuleFileNameA and RegSetValueExA explicit ascii versions | 14:13.39 |
| vtorri | well, the linker does not say that | 14:13.54 |
| | :) | 14:13.56 |
| tor8 | yes, that's because you need -lcomdlg32 | 14:17.50 |
| | or some other standard windows library that has the GetOpenFileName function | 14:18.09 |
| | nothing to do with -DUNICODE as I understand it | 14:18.21 |
| | that just adds a #define GetOpenFileName GetOpenFileNameW | 14:18.48 |
| | and the default non-unicode is #define GetOpenFileName GetOpenFileNameA | 14:19.04 |
| | we call the W and A suffixed functions explicitly so that the -DUNICODE shouldn't be needed | 14:19.18 |
| vtorri | ok | 14:20.31 |
| | seems to work | 14:20.36 |
| | tor8: what is the classical way to provide a patch ? | 14:20.59 |
| tor8 | vtorri: check if http://git.ghostscript.com/?p=user/tor/mupdf.git;a=commit;h=ab2c0f83f6cd3273a8fa855ba12a9b0bc032e0c1 on my repo works | 14:26.43 |
| | it uses a newer glfw so check out the commit to test | 14:27.05 |
| vtorri | tor8: GLFW_LIBS := -lopengl32 -lgdi32 | 14:29.37 |
| | needed for CreateDIBSection and another function | 14:30.10 |
| | Forward 1 day (to 2017/10/13)>>> | |
Log of #mupdf at irc.freenode.net.