| | <<<Back 1 day (to 2018/08/19) | 20180820 |
| inflex | Not sure if I'm missing something obvious here, but in ui_input_key() ( gl-input.c ) I cannot seem to get shift modified keys aside from letters, ie, kK jJ is fine, but 9( 0) just shows as 99 00 (in the search bar in mupdf-gl) | 07:46.59 |
| paulgardiner | Please would someone review the commit on my master branch. Cluster seems happy with it | 07:55.59 |
| tor8 | inflex: it works on stock mupdf with the shipped freeglut | 08:12.37 |
| | paulgardiner: "Fix inability to uncheck check boxes" LGTM (but to nitpick, we use a final period or other punctuation in commit messages in mupdf) | 08:14.35 |
| paulgardiner | No probs. I'll add it. Thansk Tor | 08:14.59 |
| tor8 | "Fix the Windows build" also looks reasonable to me | 08:15.31 |
| paulgardiner | Ta | 08:16.07 |
| inflex | tor8, okay, could be something in the SDL wrapper I'm using, sorry for the trouble. | 08:47.43 |
| tor8 | inflex: at a guess -- it's giving you only raw key events, not the cooked character/text input events with shifting and keyboard layout applied | 08:49.27 |
| inflex | Agreed, that's what I'm thinking too. Thanks | 08:51.51 |
| tor8 | inflex: https://wiki.libsdl.org/Tutorials/TextInput a google search turned up this | 08:51.59 |
| paulgardiner | tor8: alerts, for which no title is specified, are coming up with "undefined". The specs say, when not present use "Adobe Acrobat". I have a patch that does that, but I'm just wondering if we'd prefer "MuPDF". | 14:34.46 |
| tor8 | this is the dialog window title? | 14:36.14 |
| | yeah, I think it'd be a bit misleading to use "Adobe Acrobat" there | 14:36.30 |
| paulgardiner | Yeah, the dialog title. | 14:43.57 |
| | MuPDF might look odd within SmartOffice. Not sure what to use. | 14:44.30 |
| tor8 | Maybe "PDF Javascript Alert"? | 14:44.54 |
| kens | "No Title" | 14:45.02 |
| tor8 | or a shorter "PDF Alert" | 14:45.14 |
| paulgardiner | Yeah that sounds good. | 14:47.23 |
| | Patch is on my master... cluster test running | 15:06.39 |
| tor8 | paulgardiner: LGTM | 15:12.18 |
| paulgardiner | Thanks | 15:12.34 |
| | Forward 1 day (to 2018/08/21)>>> | |
Log of #mupdf at irc.freenode.net.