| | <<<Back 1 day (to 2019/05/15) | 20190516 |
| fredross-perry | ator: In order to build the latest source for Android, I had to add -DHAVE_LCMS2MT. Does that make sense? Otherwise, I get a compile error in color-lcms.c, missing lcms2.h. | 16:34.35 |
| | Robin ^^^ | 16:35.57 |
| Robin_Watts | Urm... yes. | 16:36.33 |
| | If you have LCMS2MT then you need to tell the makefile that. Otherwise it tries to use the system lcms2. | 16:37.01 |
| fredross-perry | I know nothing about LCMS2MT. Apparently Android has it, 'cause if -DHAVE_LCMS2MT it builds and runs. But I've not been doing -DHAVE_LCMS2MT before. Has there been a change since 1.15 where this is now required? | 16:40.51 |
| | re: fc30da1 | 16:44.11 |
| Robin_Watts | LCMS2MT = *our* version of lcms2. | 16:52.24 |
| | the thing that lives in thirdparty/lcms/ | 16:52.34 |
| | the thing that lives in thirdparty/lcms2/, sorry. | 16:52.46 |
| | The difference (either for 1.15 or just after, I forget) is that we now work with system lcms2's, not just our own. | 16:53.25 |
| | I believe our normal makefile spots the existence of thirdparty/lcms2 and sets the HAVE_LCMS2MT thing. | 16:53.54 |
| | I bet that just got forgotten for android builds. | 16:54.03 |
| fredross-perry | Likely. Thanks. | 17:05.03 |
| | ator, sebras: I think we need this for Android: http://git.ghostscript.com/?p=user/fred/mupdf.git;a=commit;h=fbd267b6e10fbf64afbc48840e7d70434443f4bd | 18:37.02 |
| ator | fredross-perry: ah, yes. LGTM. | 20:14.21 |
| ztravis | hi, I just submitted a patch for this bug: https://bugs.ghostscript.com/show_bug.cgi?id=699484 | 21:00.08 |
| | happy to provide more information if needed. let me know if y'all have different preferences/procedures for contributions! | 21:02.38 |
| | I also have a feature/improvement in the works (writing paletted PNGs where possible, which in my experience is actually quite often - significantly smaller output at no loss) - is the bug tracker appropriate for this, or do you have another suggestion? | 21:08.52 |
| Robin_Watts | ztravis: discussing stuff with us here is often best to avoid disappointment, but yes, the bug tracker is a fine place for patches. | 23:32.06 |
| | Forward 1 day (to 2019/05/17)>>> | |
Log of #mupdf at irc.freenode.net.