| | <<<Back 1 day (to 2020/02/26) | Fwd 1 day (to 2020/02/28)>>> | 20200227 |
| avih | ator: minor fix from yesterday's patch (just the diff from it) https://0x0.st/ibPB.txt comments? | 10:38.08 |
| paulgardiner | Robin_Watts: there are three commits up for review on my master, fixing the problems we've been discussing. I have a cluster job running. | 13:40.45 |
| Robin_Watts | paulgardiner: Your second commit uses // comments. I think style says we don't use them. | 15:28.52 |
| paulgardiner | Oh right. Forgot. I'll sort that out. | 15:29.13 |
| Robin_Watts | though, actually, that seems to be slipping a bit, according to grep... | 15:30.15 |
| | paulgardiner: Last commit: size_t n = 1; why 1 ? | 15:32.00 |
| | why not 0? | 15:32.03 |
| | oh. ignore me. | 15:32.21 |
| paulgardiner | :-) | 15:32.25 |
| Robin_Watts | and the last hunk looks like something you did for debugging, but shouldn't be left in? | 15:32.53 |
| | (or if it should be left in, the indentation is wrong) | 15:33.22 |
| paulgardiner | Same commit? | 15:39.39 |
| | I'm code blind. I'm not seeing it. | 15:40.35 |
| | Robin_Watts: I still don't see the bad hunk, but I've updated the comments. | 16:24.20 |
| Robin_Watts | paulgardiner: sorry, didn't see you. | 16:24.38 |
| | just a tick... | 16:24.41 |
| | I hate the variable 'l'. | 16:25.24 |
| | cos if (l) and if (1) are almost indistinguishable in some fonts. | 16:25.38 |
| | Last commit. | 16:25.53 |
| | Last hunk | 16:25.59 |
| | https://git.ghostscript.com/?p=user/paulg/mupdf.git;a=commitdiff;h=e5f08b388e7caa52271d66c67e5038450e27a45e | 16:26.05 |
| | You've changed from if (A &&\nB)\nblah(); to if(A)\nif(B)\nblah() | 16:26.34 |
| paulgardiner | Oh, oh oh. Yes | 16:26.47 |
| | Hang on | 16:26.59 |
| | Robin_Watts: corrected | 16:31.12 |
| Robin_Watts | lovely. lgtm. | 16:32.22 |
| | or 1gtm. | 16:32.28 |
| paulgardiner | Great ta | 16:33.08 |
| malc_ | Robin_Watts: https://www.youtube.com/watch?v=LhMRAjX95k0&list=PLLAukRknwSgFhpYsDKHY0oWpvV03Qj4AE can be handy when facing fonts, also mupdf is involved | 16:53.05 |
| | <<<Back 1 day (to 2020/02/26) | Forward 1 day (to 2020/02/28)>>> | |
Log of #mupdf at irc.freenode.net.