[gs-bugs] [Bug 691510] issues with x11 device as dynamic module

bugzilla-daemon at ghostscript.com bugzilla-daemon at ghostscript.com
Fri Jul 30 15:12:12 UTC 2010


--- Comment #6 from Hin-Tak Leung <hintak at ghostscript.com> 2010-07-30 15:12:11 UTC ---
(In reply to comment #1)
> The patch does not delete the original gdevemap. We should avoid that the same
> code piece exists more than once in the source code. Imaging someone fixes a
> bug in it and forgets the second incarnation.

It shouldn't be deleted - as it is used by mac classic build and windows build
to load xfonts. The mapping has not changed for 10 years and unlike to change,
but I agree it is not elegant.

I have thought of another alternative of addressing gsparamx and gdevemap being
shared with non-unix builds in core. One can have a smaller list of objects for
the shared x11 target than the build-in x11 target. e.g.

x11_shared=<most of OBJ>
x11_=$(x11_shared) $(GLOBJ)gdevemap.$(OBJ) $(GLOBJ)gsparamx.$(OBJ)

$(GLOBJ)X11.so : $(x11alt_) $(x11_shared)
$(CCLD) $(LDFLAGS) -shared -o $(GLOBJ)X11.so $(x11alt_) $(x11_shared) \
-L/usr/X11R6/lib -lXt -lSM -lICE -lXext -lX11 $(XLIBDIRS)

It is marginally better in that it does't involve duplicating the body of
gdevemap, but make the makefile a bit more complicated.

Configure bugmail: http://bugs.ghostscript.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the gs-bugs mailing list