[gs-bugs] [Bug 691965] New: two patches: turn gapp in x11_main into a variable main and refer by the passed app

bugzilla-daemon at ghostscript.com bugzilla-daemon at ghostscript.com
Mon Feb 14 21:02:36 UTC 2011


           Summary: two patches: turn gapp in x11_main into a variable
                    main and refer by the passed app
           Product: MuPDF
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P4
         Component: apps
        AssignedTo: tor.andersson at artifex.com
        ReportedBy: dsdutkiewicz at msn.com
         QAContact: gs-bugs at ghostscript.com
   Estimated Hours: 0.0

Created an attachment (id=7245)
 --> (http://bugs.ghostscript.com/attachment.cgi?id=7245)
first patch: remove gapp global usage in x11_main.c

this makes the code more regular but is a big patch although it really changes
no functionality of the program (attachment commit-6d89c37)

the second patch: (attachment commit-6d89c37)
- adds a clone key 'o'; this forks and execs mupdf like mupdf <filename>
<pageno> (i would have liked it to save more of mupdf's application state so
that the new window would be substituable for the old one but i had to keep
only what the new mupdf has command line options for which is enough)
- marks the pdf fd as close on exec; this is needed or else the fork inherits
the old mupdf's open file discriptor
- removes the global filename from x11_main; last of the fix up from the last
patch feel free to regroup the changes
- applies realpath on filename; this is needed as without it the filename saved
in app->filename can sometimes be relative for mupdf <filename> to work the
path needs to be absolute

the first patch must be applied before the second

i here by assign all rights to these patches to Tor and ask that i be credited
for them

Configure bugmail: http://bugs.ghostscript.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the gs-bugs mailing list